Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo - Fixing overlapping text and placeholder image #2345

Merged
merged 4 commits into from
Mar 24, 2024

Conversation

amankumarrr
Copy link
Member

@amankumarrr amankumarrr commented Mar 21, 2024

Fixed: #2344

Affected Route: /logo/ssw

Screenshot:
image

Figure: Placeholder image for the broken link

image

Figure: SSW fixed wrapping issue for color

Fixed: #2344

Affected Route: `/logo/ssw`

Screenshot: TODO
Copy link
Contributor

github-actions bot commented Mar 21, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.25% 69/27523
🔴 Branches 8.89% 24/270
🔴 Functions 1.2% 3/249
🔴 Lines 0.25% 69/27523

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 3dcd50c

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2345.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 36
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2345.azurewebsites.net

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2345.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 96
Best practices 96
Performance 39
SEO 86

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2345.azurewebsites.net

Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Deployed changes to https://app-sswwebsite-9eb3-pr-2345.azurewebsites.net

Copy link
Contributor

PageSpeed Insights

Category Score
Accessibility 90
Best practices 96
Performance 42
SEO 93

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-2345.azurewebsites.net

@amankumarrr amankumarrr merged commit 79953fa into main Mar 24, 2024
11 checks passed
@amankumarrr amankumarrr deleted the 2244-logo-fixing-ui branch March 24, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Logo UI - SSW Color block's text is wrapping
2 participants